Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests run against the review app server #4991

Open
2 tasks
romaricpascal opened this issue May 17, 2024 · 0 comments
Open
2 tasks

Ensure tests run against the review app server #4991

romaricpascal opened this issue May 17, 2024 · 0 comments
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) small story tooling

Comments

@romaricpascal
Copy link
Member

What

Have tests check that the server running on port 3000 is actually the review app and either, if not the review app:

  1. prevent tests from running altogether
  2. use a different port for the server and the tests

Choice would depend on the complexity of implementation of 2 and time available. 1. would already provide some us some safety that we run against the right server rather wasting time looking at a flurry of errors.

Why

Before starting a server with the review app, our tests check if anything's running on port 3000. However, they don't check if that server is actually the review app, which may lead to the tests running against another server entirely if the developer has other projects running on their machine (and lots of tests failing). We should make sure tests run against the appropriate server.

Who needs to work on this

Developers

## Who needs to review this

Developers

## Done when

Either

  • Tests do not start if they don't run against the review app and we created an issue to use a different port later on
  • Tests use a different port if port 3000 is already used by a project that's not the review app
@romaricpascal romaricpascal added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) tooling small story labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) small story tooling
Projects
None yet
Development

No branches or pull requests

1 participant