Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of warning text icon when border-box box sizing is applied globally #1862

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Fix display of warning text icon when border-box box sizing is applied globally #1862

merged 2 commits into from
Jul 16, 2020

Commits on Jul 16, 2020

  1. Fix warning text if border-box sizing applied globally 

    If a user applies a global box-sizing reset [1], the warning text icon is 'squished' horizontally as the border is 'accounted for' within the 29px min-width.

Explicitly use border-box sizing, as this means that the min-width reflects the actual desired width of the icon, rather than having to factor the border width in separately. As the box-sizing model is now set explicitly, it should display correctly whether the reset is applied or not.

Increase the min-width and min-height of the icon to include the border (3px border * 2 in each direction = 6px).

[1]: https://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/
    @36degrees
    36degrees committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    d425b29 View commit details
    Browse the repository at this point in the history

  2. Add to changelog

    @36degrees
    36degrees committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    317e339 View commit details
    Browse the repository at this point in the history