Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of warning text icon when border-box box sizing is applied globally #1862

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Fix display of warning text icon when border-box box sizing is applied globally #1862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d425b29
Fix warning text if border-box sizing applied globally
36degrees Jul 15, 2020
317e339
Add to changelog
36degrees Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ We’ve made fixes to GOV.UK Frontend in the following pull requests:
- [#1842: Preserve the state of conditional reveals when navigating 'back' in the browser](https://github.com/alphagov/govuk-frontend/pull/1842)
- [#1855: Hint component can render block-level elements as valid HTML](https://github.com/alphagov/govuk-frontend/pull/1855)
- [#1861: Fix the display of checkboxes when border-box box sizing is applied globally](https://github.com/alphagov/govuk-frontend/pull/1861)
- [#1862: Fix display of warning text icon when border-box box sizing is applied globally #1862](https://github.com/alphagov/govuk-frontend/pull/1862)

## 3.7.0 (Feature release)

Expand Down
6 changes: 4 additions & 2 deletions src/govuk/components/warning-text/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,15 @@
.govuk-warning-text__icon {
@include govuk-font($size: false, $weight: bold);

box-sizing: border-box;

display: inline-block;

position: absolute;
left: 0;

min-width: 29px;
min-height: 29px;
min-width: 35px;
min-height: 35px;
margin-top: -7px;

@include govuk-media-query($from: tablet) {
Expand Down