This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Restrict merge access to the Publishing API #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doing this in advance of enabling CD for this app, so that we can get use to the restriction and have more time to address any issues it causes. |
Previously we agreed that on a beta Continuous Deployment involving this repo, with the caveat that any changes should only be mergeable by people who would otherwise be manually deploying them.
benthorner
force-pushed
the
restrict-merge-publishing-api
branch
from
bc9154c
to
05dbab3
Compare
ChrisBAshton
approved these changes
Jun 23, 2020
| @@ -107,7 +107,7 @@ | |||
| end | |||
|
|
|||
| def given_theres_a_repo(archived: false, | |||
| full_name: "alphagov/publishing-api", | |||
| full_name: "alphagov/smart-sandwich", | |||
There was a problem hiding this comment.
full_name: "alphagov/some-repo-name",
...might be better, if less fun :)
There was a problem hiding this comment.
Oh, we're definitely sticking with "smart-sandwich". It's a critical part of our infra.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/aW59k3Tf/170-activate-continuous-deployment-for-the-publishing-api
Previously we agreed that on a beta Continuous Deployment involving
this repo, with the caveat that any changes should only be mergeable
by people who would otherwise be manually deploying them.