This repository has been archived by the owner on Apr 30, 2021. It is now read-only.
concourse-operator: updates for concourse v6.6.0 #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 14, 2020 17:07
we updated the concourse version and need to keep the library version used by the operator in sync
some of the latest versions of dependencies require go1.13+ (as they rely on additions to the errors packages).
adds an environment variable that can be used to turn on the verbose http client logging from the concourse client lib. this can be useful to see more details about where a request is failing to concourse
the way pipeline validation is performed has changed in recent version of the concourse libraries ... this makes it compatible the new validation also appears to be better at catching issues and raised a couple of problems with our tests which are resolved here by fixing the pipeline inputs to be valid when they should be manually using yaml.Unmarshal also no longer appears to produce a valid atc.Config struct ... so we switch to the built in unmarshaller
the function signature for CreateOrUpdatePipeline has changed ... update it for compatibility with latest libs
it appears we were pulling the id-token from the JWT token response and using it as the bearer token for the client. I'm not sure why we were doing this, but it appears to have been introduced shortly after the concourse authentication changes in v6.2. I suspect whatever the original problem was has not been fixed, and so we ended up using the wrong token after the upgrade to 6.6. using the standard AuthToken response resolves our current issues with the password authenticate for the operator not working against v6.6 this change likely makes the operator no-longer compatible with versions prior to 6.6
szd55gds
approved these changes
Oct 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves authentication issues between the concourse-operator and concourse API for v6.6.0
Notes