-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new environment
property to Plek
#39
Conversation
Provides an easy way to identify the environment we’re currently running under. For backward compatibility purposes, what used to be “preview” (i.e. `preview.alphagov.co.uk`) is now referred to as “integration” using this API. This provides a stable value for any applications using this new API without needing to be concerned about distinctions between preview and the new integration environment.
f6ac729
to
cafa85b
Compare
Use ClimateControl to stub the environment instead of directly modifying the ENV hash. This allows the tests to be run in a random order.
cafa85b
to
d2e8330
Compare
I don't have strong opinions on this. We do however have an environment variable, |
I think managing and maintaining multiple vars per app might be worse, personally. Open to opinions from others. |
The reason being that if we have implicit dependencies on one environment variable, it can create additional complexity if the use case changes later. We've actively tried to reduce the use of such variables in our Puppet code base, for example. |
This better explains what I'm referring to:
|
Closing in favour of a behaviour-specific variable. |
Provides an easy way to identify the environment we’re currently
running under.
For backward compatibility purposes, what used to be “preview” (i.e.
preview.alphagov.co.uk
) is now referred to as “integration” usingthis API. This provides a stable value for any applications using this
new API without needing to be concerned about distinctions between
preview and the new integration environment.
/cc @alexmuller
Also included, making tests pass in Jenkins. Seems it's been a while since Plek development occurred.