Release version 4.1.0. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been the default for new Gemfiles since a major security incident at rubygems.org in 2013[1]. While we're at it, also fix a missing https in a link in the README. [1]: https://venturebeat.com/business/rubygems-org-hacked-interrupting-heroku-services-and-putting-millions-of-sites-using-rails-at-risk/
|
On second thoughts, let's release a 4.1.0 now to get us unblocked and then include some actually-breaking stuff in 5.0 shortly after. That way we don't risk blocking Replatforming on changes that aren't strictly needed for Replatforming, but we can still move just as fast on the other Plek cleanup stuff in the likely event that it goes smoothly. |
kevindew
force-pushed
the
sengi/version
branch
from
0abe17c
to
cdadda1
Compare
kevindew
approved these changes
Oct 3, 2022
kevindew
added a commit
to alphagov/gds-api-adapters
that referenced
this pull request
Oct 3, 2022
This has been deprecated [1] since Plek 4.1 [2]. Instead we can use forego the need for a current method and call find directly. [1]: alphagov/plek#94 [2]: alphagov/plek#92
kevindew
added a commit
to alphagov/gds-api-adapters
that referenced
this pull request
Oct 3, 2022
This has been deprecated [1] since Plek 4.1 [2]. Instead we can use forego the need for a current method and call find directly. [1]: alphagov/plek#94 [2]: alphagov/plek#92
kevindew
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Oct 3, 2022
Plek 4.1 [1] deprecates the Plek.current method. This resolves this gem emitting deprecation warnings. [1]: alphagov/plek#92
kevindew
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Oct 3, 2022
Plek 4.1 [1] deprecates the Plek.current method. This resolves this gem emitting deprecation warnings. This also updates the Gemfile.lock of this gem to use the new version. [1]: alphagov/plek#92
kevindew
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Oct 3, 2022
Plek 4.1 [1] deprecates the Plek.current method. This resolves this gem emitting deprecation warnings. This also updates the Gemfile.lock of this gem to use the new version. [1]: alphagov/plek#92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we wanted to be super strict, we could view removing the unused setter methods for
parent_domainandexternal_domainas a compatibility-breaking API change. There isn't a single usage of these anywhere though, so in practice it's more helpful to consider this a minor release as it's supposed to be 100% compatible with all existing usage.Also, start using
httpswhen fetching gem dependencies during build.