Bump rubocop-govuk from 4.17.0 to 4.17.1

This also fixes two new violations Original (weird) commit message below --- updated-dependencies: - dependency-name: rubocop-govuk dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ynda Jas <yndajas@gmail.com>
alphagov · May 22, 2024 · 66dfe99 · 66dfe99
1 parent d41a58c
commit 66dfe99
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -631,13 +631,13 @@ GEM
       rubocop (~> 1.41)
     rubocop-factory_bot (2.25.1)
       rubocop (~> 1.41)
-    rubocop-govuk (4.17.0)
+    rubocop-govuk (4.17.1)
       rubocop (= 1.63.5)
       rubocop-ast (= 1.31.3)
-      rubocop-rails (= 2.24.1)
+      rubocop-rails (= 2.25.0)
       rubocop-rake (= 0.6.0)
       rubocop-rspec (= 2.29.2)
-    rubocop-rails (2.24.1)
+    rubocop-rails (2.25.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)

diff --git a/test/controllers/batch_invitations_controller_test.rb b/test/controllers/batch_invitations_controller_test.rb
@@ -15,7 +15,7 @@ def users_csv(filename = "users.csv")
   context "GET new" do
     should "render a form" do
       get :new
-      assert_response 200
+      assert_response :ok
       assert_select "input[type=file]"
     end
 

diff --git a/test/controllers/organisations_controller_test.rb b/test/controllers/organisations_controller_test.rb
@@ -13,7 +13,7 @@ class OrganisationsControllerTest < ActionController::TestCase
 
     should "list organisations" do
       get :index
-      assert_response 200
+      assert_response :ok
       assert_select "td", "Ministry of Funk (MoF)"
     end
   end