Delete migrations from before 2023 #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think there's much utility in keeping very old migrations hanging around in the codebase. They make it slightly harder to grep and apply style/linting changes and are very unlikely to be re-run.
chrisroos
approved these changes
Jun 21, 2023
ChrisBAshton
added a commit
to alphagov/content-publisher
that referenced
this pull request
Sep 16, 2024
There is precedent in removing old migrations, e.g. in alphagov/whitehall#7675 and alphagov/signon#2217 Keeping migrations around makes it harder to grep, and to apply changes en-masse (such as linting updates). #3198 is currently failing because of a single lint failure in one of these migration files: ``` Offenses: db/migrate/20200206153428_remove_null_constraints_from_whitehall_migrations.rb:3:5: C: Rails/BulkChangeTable: You can use change_table :whitehall_migrations, bulk: true to combine alter queries. (https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-change_table, https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/Table.html) change_column_null :whitehall_migrations, :document_type, true ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 603 files inspected, 1 offense detected ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's much utility in keeping very old migrations hanging around in the codebase. They make it slightly harder to grep and apply style/linting changes and are very unlikely to be re-run.