Add Cucumber scenario for manuals-publisher #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the pattern of the other publishing tests. One of the motivations for adding a Smoke test was to catch the sort of timeout problem we saw recently where the /manuals index page was taking too long to load. Unfortunately, I don't think this test would've caught that problem because the test signon user doesn't have any manuals to load! Irrespective, I still think it's useful to have this sort of test to ensure we get an early warning if we've really broken something. The test signon user has the manuals-publisher permission. You can run this test locally by using the signon credentials stored in the Smokey job configuration in the integration Jenkins instance. I've set the scenario as `@high` priority which means (if I understand the README[1] correctly) that it'll generate a pager alert if it fails. This is the same priority as the other scenarios in this feature although it's not obvious to me that it's definitely the right thing to do. [1]: https://github.com/alphagov/smokey/blob/master/README.md#prioritising-scenarios
4 tasks
floehopper
approved these changes
Apr 20, 2017
|
Thanks @floehopper. I'm going to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the pattern of the other publishing tests.
One of the motivations for adding a Smoke test was to catch the sort of timeout
problem we saw recently where the /manuals index page was taking too
long to load. Unfortunately, I don't think this test would've caught
that problem because the test signon user doesn't have any manuals to
load! Irrespective, I still think it's useful to have this sort of test
to ensure we get an early warning if we've really broken something.
The test signon user has the manuals-publisher permission. You can run
this test locally by using the signon credentials stored in the Smokey
job configuration in the integration Jenkins instance.
I've set the scenario as
@highpriority which means (if I understand theREADME correctly) that it'll generate a pager alert if it fails. This
is the same priority as the other scenarios in this feature although
it's not obvious to me that it's definitely the right thing to do.