Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add healthcheck scenario for collections #731

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

benthorner
Copy link
Contributor

https://trello.com/c/epNWudCR/176-write-an-rfc-for-continuous-deployment-and-seek-review

Previously this app didn't have a healthcheck endpoint. This adds
a scenario to explicitly check the new endpoint 1 as a standard
safety check for apps that have Continuous Deployment enabled.

Testing

You should manually test your PR before merging.

This app doesn't have CI setup, and it would be misleading to do so:
the behaviour of the tests changes depending on the environment they
are run in. You should manually test in applicable environments,
until you are confident your change is not a breaking one.

Example steps to test in Integration:

  • Click "Configure" for the Smokey job
  • Change the "Branch specifier" to the name of your branch
  • Run a new build of the Smokey project and check the results

Deployment

You need to manually deploy your PR after merging.

Steps to deploy a change:

The manual Smokey job will pick up changes on master automatically. You only need to do a manual deployment for the continuous Smokey loop.

Previously this app didn't have a healthcheck endpoint. This adds
a scenario to explicitly check the new endpoint [1] as a standard
safety check for apps that have Continuous Deployment enabled.

[1]: alphagov/collections#1976
@benthorner benthorner merged commit a79d996 into master Oct 15, 2020
@benthorner benthorner deleted the add-collections-healthcheck branch October 15, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants