Remove unused layouts and govuk_template
#2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
force-pushed
the
remove-govuk-template
branch
from
58d4fa6
to
2b87455
Compare
|
Rebased to resolve a doc conflict after #2662 |
alex-ju
changed the title
govuk_templategovuk_template
injms
reviewed
Jan 18, 2022
injms
reviewed
Jan 18, 2022
| @@ -1,6 +1,6 @@ | |||
| # Slimmer Templates | |||
|
|
|||
| ## `gem_layout` | |||
| ## `gem_layout` (default) | |||
kevindew
added a commit
that referenced
this pull request
Mar 24, 2022
This post-processor doesn't seem to work with Sprockets 4. On investigation this was added for compatibility with govuk_template - which was removed in Jan 2022 [1]. Therefore this code can be removed. [1]: #2663
kevindew
added a commit
that referenced
this pull request
Mar 30, 2022
This code causes an error with Sprockets 4. Once I started looking into it I realised it was no longer needed as it was added for css.erb files that were a part of govuk_template [1]. Since January 2022 [2] we no longer use govuk_template and thus no longer have css.erb files. [1]: 7436c5e [2]: #2663
hannako
added a commit
that referenced
this pull request
Jul 20, 2023
This asset was missed from #2663 Travel advice publisher requests the print.html layout from static, which requires this asset[1] [1] https://github.com/alphagov/static/blob/main/app/views/root/print.html.erb#L15
hannako
added a commit
that referenced
this pull request
Jul 20, 2023
This asset was missed from #2663 Asset imported from [1] Travel advice publisher requests the print.html layout from static, which requires this asset[2] [1] https://github.com/alphagov/govuk_template/blob/master/source/assets/images/gov.uk_logotype_crown_invert.png [2] https://github.com/alphagov/static/blob/main/app/views/root/print.html.erb#L15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As all frontend applications are now using
gem_layoutor a variation of this, we can now remove unused layouts (core_layoutandheader_footer_only) and 'non-layout templates' (campaignandproposition_menu) and make thegem_layoutdefault.This also means we can remove all the assets that are only being used within these templates – and more importantly drop the dependency on govuk_template. However, a few assets from
govuk_template(apple-touch-icon*) need to be ported.I have also tested this change manually in integration by accessing a range of pages rendered by various frontend applications while keeping an eye on logs.
Why
To keep our codebase clean and prevent deprecated layouts from being used.