Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery.history.js dependency on $.browser #626

Merged
merged 3 commits into from Jul 24, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 24, 2015

jQuery.history is used only by jQuery.tabs. It's use of the deprecated jQuery.browser is blocking the upgrade of jQuery. There is a plan to design away tabs but to unblock the jQuery upgrade this PR adds a shim.

Replace $.browser uses with $.historyBrowserShim. The same approach as alphagov/Accessible-Media-Player#7

Tested on /bank-holidays on IE7 and Safari to confirm existing behaviour still works.

There are some whitespace changes, I recommend reviewing with ?w=1

Unblocks https://trello.com/c/BMpUGtKT/94-upgrade-jquery-on-gov-uk

fofr added 3 commits Jul 24, 2015
jQuery.history is used only by jQuery.tabs. It's use of
the deprecated jQuery.browser is blocking the upgrade of
jQuery. There is a plan to design away tabs.

Replace uses with a `historyBrowserShim`. The same approach as
alphagov/Accessible-Media-Player#7

* Refer to local shim rather than jQuery
Based on the original jQuery.browser test suite, check the new shim
logic matches.

https://github.com/jquery/jquery/blob/1.9.1/test/data/ua.txt
dsingleton added a commit that referenced this pull request Jul 24, 2015
Remove jquery.history.js dependency on $.browser
@dsingleton dsingleton merged commit 53b0b69 into master Jul 24, 2015
1 check passed
1 check passed
default "Build #546 succeeded on Jenkins"
Details
@dsingleton dsingleton deleted the remove-browser branch Jul 24, 2015
@fofr fofr mentioned this pull request Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.