Remove jquery.history.js dependency on $.browser #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery.history is used only by jQuery.tabs. It's use of the deprecated jQuery.browser is blocking the upgrade of jQuery. There is a plan to design away tabs. Replace uses with a `historyBrowserShim`. The same approach as alphagov/Accessible-Media-Player#7 * Refer to local shim rather than jQuery
Based on the original jQuery.browser test suite, check the new shim logic matches. https://github.com/jquery/jquery/blob/1.9.1/test/data/ua.txt
dsingleton
added a commit
that referenced
this pull request
Jul 24, 2015
Remove jquery.history.js dependency on $.browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery.history is used only by jQuery.tabs. It's use of the deprecated jQuery.browser is blocking the upgrade of jQuery. There is a plan to design away tabs but to unblock the jQuery upgrade this PR adds a shim.
Replace
$.browseruses with$.historyBrowserShim. The same approach as alphagov/Accessible-Media-Player#7Tested on
/bank-holidayson IE7 and Safari to confirm existing behaviour still works.There are some whitespace changes, I recommend reviewing with
?w=1Unblocks https://trello.com/c/BMpUGtKT/94-upgrade-jquery-on-gov-uk