Fall back to "en" locale for "en-GB" #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smart answers uses a "en-GB" locale, but we don't have that in the app. This causes a lot of 404's to be returned and missing translations in smart answers (presumably).
|
looks good 🚢 |
|
Should smart answers use |
|
@fofr I've added an issue here: alphagov/smart-answers#2925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smart answers uses a "en-GB" locale, but we don't have that in this app. This causes a lot of 404's to be returned and missing translations in smart answers (presumably).
Kibana reports about 3.3 million
404on this route over the last 24 hours:This is also caused by smart-answers cache being broken, which is fixed in alphagov/slimmer#183.
https://trello.com/c/D9HmkJwI