Specify Ruby version for publish workflow #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-fix-publish-workflow
branch
from
0bf899c
to
b398d17
Compare
GitHub Actions is warning about deprecation of Node 12 actions, bump actions/checkout to fix this.
GitHub Actions has deprecated the use of the `set-output` command [[1]], we should use environment files instead. [1]: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lfdebrux
force-pushed
the
ldeb-fix-publish-workflow
branch
from
b398d17
to
c871eec
Compare
The ruby/setup-ruby action needs a version of Ruby specified to work. Previously it was reading the `.ruby-version` file, however we removed that in commit 2aa58cc. We could restore that file, but because `ruby-install` doesn't support loose version specifiers, we'd have to keep it maintained. Instead we just tell the action to install the latest version of Ruby 3.
lfdebrux
force-pushed
the
ldeb-fix-publish-workflow
branch
from
c871eec
to
3bc4b87
Compare
lfdebrux
changed the title
richardTowers
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the publish workflow.
The ruby/setup-ruby action needs a version of Ruby specified to work. Previously it was reading the
.ruby-versionfile, however we removed that in commit 2aa58c. We could restore that file, but becauseruby-installdoesn't support loose version specifiers, we'd have to keep it maintained. Instead we just tell the action to install the latest version of Ruby 3.