Remove mentions of org-ql-find-heading, org-ql-find-path from Changelog. #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't |
|
I'm not sure what you mean. According to 5768c68, As it pertains to the changelog, it should be removed from the 0.7 release subheading IMO. As you prefer. |
|
I've adjusted the commit message to make things a bit clearer. See if that helps and let me know if not. |
This fixes the case in which a user calls org-ql-find from a narrowed buffer and chooses a result outside the restriction. This is already done in, e.g. org-ql-open-link; it's just an oversight here.
I don't fully understand why this is the correct fix, because I don't know where the raw heading text is being linkified (it seems like the :raw-value property should be the unlinkified text), but this seems to work correctly now. If it turns out to break something else, we'll find out and fix it. Fixes #282. Reported-by: Jacob Boxerman <https://github.com/jakebox>
These commands were removed in 5768c68, but they were still mentioned in the release that was going to incorporate those two functions, v0.7. This commit removes the mention of those two functions from the v0.7 subheading in the changelog. Note that `org-ql-find-path` was re-introduced in v0.8, so it remains under that subheading as a separate addition.
|
Ah, my mistake. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commands were removed in 5768c68, but they were still mentioned in the release that was going to incorporate those two functions, v0.7.