Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving listeners to events on the DOM, docs, renaming #28

Conversation

alexander-alvarez
Copy link
Contributor

First jab at making things a bit more idiomatic and reactive.

  • removed the instances of .on and .off from html elements, in favor of adding actions directly on those elements.

First stab at adding documentation, will add more as I comb through the code

@taras
Copy link
Contributor

taras commented Nov 30, 2016

This is looking great so far. What else do you need to do to get this ready?

@alexander-alvarez
Copy link
Contributor Author

seems the scroll event isn't being triggered in the ember 1.13 branch or something
the only difference I can thing of is the jquery versions jquery#3.1.1 vs jquery#2.1.4

I can add back the listener for only the scroll event if we don't know how to remedy it?

@alexander-alvarez
Copy link
Contributor Author

absorbed by
#29

@alexander-alvarez alexander-alvarez deleted the listeners-and-docs branch December 7, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants