Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting rid of warning in TCP iface #342

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Getting rid of warning in TCP iface #342

merged 4 commits into from
Oct 15, 2024

Conversation

alphaville
Copy link
Owner

@alphaville alphaville commented Mar 26, 2024 •
edited
Loading

Main Changes

  • Handling kill code in TCP iface

Associated Issues

TODOs

  • All tests must pass
  • Update CHANGELOG(s)
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)

@alphaville
Addressing issue #341
4eff6ad 
About:
- handling kill code in TCP iface
- Update changelog (v0.8.1)
@alphaville alphaville self-assigned this Mar 26, 2024
@alphaville alphaville added the rust issue related to the code Rust library label Mar 27, 2024
@alphaville alphaville marked this pull request as ready for review October 14, 2024 15:24
ruairimoran
ruairimoran approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alphaville alphaville merged commit d302884 into master Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruairimoran ruairimoran ruairimoran approved these changes

Assignees

@alphaville alphaville

Labels
rust issue related to the code Rust library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning when creating TCP server
2 participants
@alphaville @ruairimoran