Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing/bcc: upgrade to 0.9.0 #7628

Closed
wants to merge 1 commit into from
Closed

testing/bcc: upgrade to 0.9.0 #7628

wants to merge 1 commit into from

Conversation

acj
Copy link
Contributor

@acj acj commented May 7, 2019

No description provided.

@probot-autolabeler probot-autolabeler bot added the R-testing Testing repository label May 7, 2019
@acj acj marked this pull request as ready for review May 7, 2019 00:18
andypost
andypost reviewed May 9, 2019
View reviewed changes
testing/bcc/APKBUILD Outdated Show resolved Hide resolved
@andypost andypost added the A-upgrade Upgrades an abuild label May 9, 2019
@acj acj mentioned this pull request May 12, 2019
Closed
@acj
Copy link
Contributor Author

acj commented May 17, 2019

@andypost This is ready for another look.

@acj acj mentioned this pull request May 19, 2019
Closed
maxice8
maxice8 requested changes May 20, 2019
View reviewed changes
Copy link
Contributor

@maxice8 maxice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

for commit 8da766e0def34c1cda652b258f86cfc6ecb2cd29:
Why not just merge both commits ?

@acj
Copy link
Contributor Author

acj commented May 21, 2019

@maxice8 I was keeping them separate so that the change was clear for the first reviewer. I just merged the commits and pushed.

maxice8
maxice8 approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@maxice8 maxice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ikke
Copy link
Contributor

Ikke commented Jun 2, 2019

0.10.0 is out (see #8411)

@kaey
Copy link
Contributor

kaey commented Jun 2, 2019

I don't think it's worth making separate package for libbpf until they make a stable release (bcc doesn't build against master branch of libbpf for example)

@acj
Copy link
Contributor Author

acj commented Jun 3, 2019

@Ikke @maxice8 This PR was approved two weeks ago. Can we merge this first and then deal with 0.10?

@kaey At the beginning my branch was similar to yours, but the reviewers asked for a separate package for libbpf. That's already done. The libbpf maintainers cut their first release last week, and we're dealing with the version change in #8225. The 0.0.3 release builds fine for me, as does master.

@algitbot
Copy link

algitbot commented Jun 3, 2019

Merged in 0e82cfc by @Ikke. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Jun 3, 2019
algitbot pushed a commit that referenced this pull request Jun 3, 2019
@acj @Ikke
testing/bcc: upgrade to 0.9.0
0e82cfc 
Closes GH-7628
@acj acj deleted the bcc-0.9 branch June 3, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypost andypost andypost left review comments

@TBK TBK TBK left review comments

@maxice8 maxice8 maxice8 approved these changes

Assignees
No one assigned
Labels
A-upgrade Upgrades an abuild R-testing Testing repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@acj @Ikke @kaey @algitbot @andypost @TBK @maxice8