-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing/bcc: upgrade to 0.9.0 #7628
Conversation
@andypost This is ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for commit 8da766e0def34c1cda652b258f86cfc6ecb2cd29:
Why not just merge both commits ?
@maxice8 I was keeping them separate so that the change was clear for the first reviewer. I just merged the commits and pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0.10.0 is out (see #8411) |
I don't think it's worth making separate package for libbpf until they make a stable release (bcc doesn't build against master branch of libbpf for example) |
@Ikke @maxice8 This PR was approved two weeks ago. Can we merge this first and then deal with 0.10? @kaey At the beginning my branch was similar to yours, but the reviewers asked for a separate package for libbpf. That's already done. The libbpf maintainers cut their first release last week, and we're dealing with the version change in #8225. The 0.0.3 release builds fine for me, as does master. |
Merged in 0e82cfc by @Ikke. Thanks for your contribution! (This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.) |
No description provided.