Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community/lld: disable test eh-frame-hdr-augmentation on armhf & armv7 #8171

Closed
wants to merge 1 commit into from

Conversation

TBK
Copy link
Contributor

@TBK TBK commented May 27, 2019

No description provided.

@probot-autolabeler probot-autolabeler bot added the R-community Community repository label May 27, 2019
@TBK
Copy link
Contributor Author

TBK commented May 27, 2019

pfffffffffffffssssssssssssssssssssssssssssssssssssss llvm issue tracking what a mess 😭

@TBK TBK closed this May 27, 2019
@TBK TBK deleted the community/lld branch May 27, 2019 02:32
@TBK TBK restored the community/lld branch May 27, 2019 02:36
@TBK TBK reopened this May 27, 2019
@TBK TBK force-pushed the community/lld branch 2 times, most recently from e6cdb38 to 70fbc38 Compare May 27, 2019 02:45
@TBK TBK changed the title community/lld: fix test/ELF/eh-frame-hdr-augmentation community/lld: disable check for armv7 May 27, 2019
@Ikke
Copy link
Contributor

Ikke commented May 27, 2019

@TBK Did you verify that it's the tests that are broken? (just to be sure)

@Ikke Ikke added A-fix Fixes an abuild S-waiting-for-feedback Waiting for a question to be answered or something to be clarified labels May 27, 2019
@TBK
Copy link
Contributor Author

TBK commented May 27, 2019

ELF/eh-frame-hdr-augmentation.s is broken on armv7 (https://build.alpinelinux.org/buildlogs/build-3-10-armv7/community/lld/lld-7.0.1-r0.log). I tried to patch the issue but I could not figure out LLVM svn/git reference system so I gave up in the end.

armhf I do not know. It was disabled in 2017 88b05a1#diff-458e5545a50ba561f5a3275d395e8dd9.

I will enable and see if it passes.

@TBK TBK force-pushed the community/lld branch 2 times, most recently from 2c3f442 to 017925a Compare May 27, 2019 12:38
@TBK
Copy link
Contributor Author

TBK commented May 27, 2019

Both armhf & armv7 fails due to the fact that ELF/eh-frame-hdr-augmentation.s is broken on 32bit arm in 7.x releases - https://cloud.drone.io/alpinelinux/aports/5532

llvm/llvm-project@c8955e2

@TBK TBK force-pushed the community/lld branch 5 times, most recently from d764d27 to 6d8d92f Compare May 27, 2019 13:35
@TBK TBK changed the title community/lld: disable check for armv7 community/lld: disable test eh-frame-hdr-augmentation armhf & armv7 May 27, 2019
@TBK
Copy link
Contributor Author

TBK commented May 27, 2019

After some digging. We can apparently just delete the test file and that disables it. So I have done that for the two arm arches.

@TBK TBK changed the title community/lld: disable test eh-frame-hdr-augmentation armhf & armv7 community/lld: disable test eh-frame-hdr-augmentation on armhf & armv7 May 27, 2019
@algitbot
Copy link

Merged in 643a96e by @Ikke. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this May 27, 2019
@TBK TBK deleted the community/lld branch May 27, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-fix Fixes an abuild R-community Community repository S-waiting-for-feedback Waiting for a question to be answered or something to be clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants