Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cset value quotation #40

Closed

Conversation

libinyang
Copy link
Contributor

This patchset removes the quotation marks of the cset values in the ucm2 config files.
In ucm2 files, the cset values should not use quotation marks. Otherwise, the cset won't work.

There should be no quotation mark around 'Headphone Mic' and 'Headset Mic'
when setting 'Input Source'. Otherwise, it won't work.

Signed-off-by: Libin Yang <libin.yang@intel.com>
cset value should not use quotation mark.

Signed-off-by: Libin Yang <libin.yang@intel.com>
cset value should not use quotation mark.

Signed-off-by: Libin Yang <libin.yang@intel.com>
cset value should not use quotation mark.

Signed-off-by: Libin Yang <libin.yang@intel.com>
@libinyang
Copy link
Contributor Author

The first 2 patches are tested. The other 2 patches are not tested, but they should be necessary based on the first 2 patches test result.

Copy link
Contributor

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

perexg added a commit to alsa-project/alsa-lib that referenced this pull request Jul 27, 2020
This comit fixes the enum value string parser
(fixes aaf3a08).

BugLink: alsa-project/alsa-ucm-conf#40
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
@perexg
Copy link
Member

perexg commented Jul 27, 2020

It's fault in alsa-lib. Fixed in the above commit.

@perexg perexg closed this Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants