aplay: improve xrun logs #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the --fatal-errors happen, nothing is provided to the user even when the '-v' verbose option is specified. This patch adds the fatal error exit after dumping the logs. No functionality change, just better information on what just happened. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
When the '-v' or '--test-position' options are used, the 'tstamp' is shown as zero. Unconditionally enable the timestamps and choose the timestamp time based on the 'monotonic' variable. Example log: Status(R/W) (standalone avail=36 delay=924): state : RUNNING trigger_time: 2045.504937 tstamp : 2190.754602 delay : 924 avail : 36 avail_max : 444 Status(R/W) (standalone avail=44 delay=912): state : RUNNING trigger_time: 2045.504937 tstamp : 2190.754852 delay : 912 avail : 48 avail_max : 48 underrun!!! (at least 471.161 ms long) Status: state : XRUN trigger_time: 2190.786234 tstamp : 2191.257392 delay : 0 avail : 1412 avail_max : 1412 aplay: xrun:1690: fatal underrun: Success Alternatively a new option could be added to control the behavior. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
perexg
pushed a commit
that referenced
this pull request
Dec 12, 2023
When the '-v' or '--test-position' options are used, the 'tstamp' is shown as zero. Unconditionally enable the timestamps and choose the timestamp time based on the 'monotonic' variable. Example log: Status(R/W) (standalone avail=36 delay=924): state : RUNNING trigger_time: 2045.504937 tstamp : 2190.754602 delay : 924 avail : 36 avail_max : 444 Status(R/W) (standalone avail=44 delay=912): state : RUNNING trigger_time: 2045.504937 tstamp : 2190.754852 delay : 912 avail : 48 avail_max : 48 underrun!!! (at least 471.161 ms long) Status: state : XRUN trigger_time: 2190.786234 tstamp : 2191.257392 delay : 0 avail : 1412 avail_max : 1412 aplay: xrun:1690: fatal underrun: Success Closes: #242 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pcm_status on xrun and a non-zero timestamp.