Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Dockerfile pulling from latest minimal notebook and building … #67

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Address Dockerfile pulling from latest minimal notebook and building … #67

merged 1 commit into from
Apr 29, 2019

Conversation

playermanny2
Copy link
Collaborator

This PR addresses updates to Dockerfile to build correctly and allow running of container with extension installed. This should allow mybinder to work properly.

Changes include

  1. Pulling from latest minimal-notebook image
  2. removing --no-build tag on jupyter link, so that it builds inside docker file, not on user request after running the image.

Issues Addressed:
#66
#61

saulshanabrook
saulshanabrook approved these changes Apr 28, 2019
View reviewed changes
Copy link
Collaborator

@saulshanabrook saulshanabrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@playermanny2 playermanny2 merged commit 2a44eef into altair-viz:master Apr 29, 2019
@playermanny2 playermanny2 deleted the update-dockerfile-to-fix-mybinder branch April 29, 2019 00:49
This was referenced Apr 29, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulshanabrook saulshanabrook saulshanabrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@playermanny2 @saulshanabrook