-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_overrunning_test_times_out is flaky #51
Comments
Apparently that didn't fix it. All through poking at the macOS issues today Windows didn't fail once. Ugh. https://github.com/altendky/qtrio/pull/58/checks?check_run_id=832969315 |
Been ok for awhile now... :| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FAILED C:\hostedtoolcache\windows\Python\3.6.8\x86\lib\site-packages\qtrio_tests\test_pytest.py::test_overrunning_test_times_out
https://github.com/altendky/qtrio/pull/50/checks?check_run_id=828834279
At first glance it looks like
@qtrio.host
isn't timing out properly thus resulting in a subprocess timeout instead. It doesn't seem like the subprocess launch time should be sufficient to cause this but... usually it doesn't. So, maybe that's it and the subprocess timeout just (appropriately) needs a significant bump to reduce flakiness. Unless maybe we can come up with a better way.qtrio/qtrio/_tests/test_pytest.py
Lines 4 to 23 in f81faa8
The text was updated successfully, but these errors were encountered: