Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back PyQt bound signal equality work around #190

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

altendky
Copy link
Owner

@altendky altendky commented Dec 2, 2020

Draft for:

  • Decide if you really want to be doing back-compat at this point

@altendky altendky changed the title Bring back pyqt equality work around Bring back PyQt bound signal equality work around Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #190 (676fdd0) into main (bdbd026) will decrease coverage by 0.09%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #190      +/-   ##
===========================================
- Coverage   100.00%   99.90%   -0.10%     
===========================================
  Files           35       35              
  Lines         2023     2028       +5     
  Branches       138      141       +3     
===========================================
+ Hits          2023     2026       +3     
- Misses           0        1       +1     
- Partials         0        1       +1     
Impacted Files Coverage Δ
qtrio/_core.py 99.08% <60.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbd026...676fdd0. Read the comment docs.

@altendky altendky marked this pull request as draft December 3, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant