Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have codecov wait for ci to finish #5

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

altendky
Copy link
Owner

@altendky altendky commented Dec 26, 2020

Draft for:

  • It's been awhile, did this work? Do we want this functionality?

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #5 (5553736) into main (296bd0c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   63.15%   63.15%           
=======================================
  Files           9        9           
  Lines          76       76           
  Branches        5        5           
=======================================
  Hits           48       48           
  Misses         28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296bd0c...5553736. Read the comment docs.

@gordon-epc
Copy link
Collaborator

Does this fix issue #13 ?

@altendky
Copy link
Owner Author

altendky commented Feb 3, 2021

Not related, no. This is just kind of a general CI setup question. In many cases you start with a failing response from codecov since not all the tests have run so you haven't reported coverage for every line yet. codecov then keeps responding again as it gets more info and eventually reports green, if you do reach full coverage. Theoretically this option makes codecov wait until all jobs have run before reporting back a single result of success or failure. I don't really remember if this was 'working' or not.

@altendky altendky marked this pull request as draft February 6, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants