Skip to content

Commit

Permalink
Update ModelFamily xgboost/catboost values (#677)
Browse files Browse the repository at this point in the history
* Update ModelFamily enum vals.

* Changelog

* Fix test
  • Loading branch information
dsherry committed Apr 20, 2020
1 parent b8642ca commit 70d6821
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions docs/source/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Changelog
* Remove s3fs as a dev dependency :pr:`664`
* Changed requirements-parser to be a core dependency :pr:`673`
* Replace `supported_problem_types` field on pipelines with `problem_type` attribute on base classes :pr:`678`
* Update `ModelFamily` values: don't list xgboost/catboost as classifiers now that we have regression pipelines for them :pr:`677`
* Documentation Changes
* Fixed some sphinx warnings :pr:`593`
* Fixed docstring for AutoClassificationSearch with correct command :pr:`599`
Expand Down
6 changes: 3 additions & 3 deletions evalml/model_family/model_family.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ class ModelFamily(Enum):

def __str__(self):
model_family_dict = {ModelFamily.RANDOM_FOREST.name: "Random Forest",
ModelFamily.XGBOOST.name: "XGBoost Classifier",
ModelFamily.LINEAR_MODEL.name: "Linear Model",
ModelFamily.CATBOOST.name: "CatBoost Classifier",
ModelFamily.XGBOOST.name: "XGBoost",
ModelFamily.LINEAR_MODEL.name: "Linear",
ModelFamily.CATBOOST.name: "CatBoost",
ModelFamily.NONE.name: "None"}
return model_family_dict[self.name]
2 changes: 1 addition & 1 deletion evalml/tests/pipeline_tests/test_pipelines.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def test_describe(X_y, capsys, lr_pipeline):
out, err = capsys.readouterr()
assert "Logistic Regression Binary Pipeline" in out
assert "Problem Type: Binary Classification" in out
assert "Model Family: Linear Model" in out
assert "Model Family: Linear" in out

for component in lrp.component_graph:
if component.hyperparameter_ranges:
Expand Down

0 comments on commit 70d6821

Please sign in to comment.