Remove copy_dataframe parameter, update requirements with release of Woodwork v0.0.6#1478
Remove copy_dataframe parameter, update requirements with release of Woodwork v0.0.6#1478angela97lin merged 6 commits intomainfrom
copy_dataframe parameter, update requirements with release of Woodwork v0.0.6#1478Conversation
Codecov Report
@@ Coverage Diff @@
## main #1478 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 223 223
Lines 15024 15025 +1
=======================================
+ Hits 15017 15018 +1
Misses 7 7
Continue to review full report at Codecov.
|
angela97lin
requested review from
bchen1116,
christopherbunn,
dsherry,
freddyaboulton and
jeremyliweishih
| assert arg.semantic_tags['cat col'] == {'category'} | ||
| assert arg.logical_types['cat col'] == ww.logical_types.Categorical | ||
| assert arg.semantic_tags['num col'] == {'numeric'} | ||
| assert arg.logical_types['num col'] == ww.logical_types.WholeNumber |
There was a problem hiding this comment.
WholeNumber was removed
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@angela97lin Thanks for the fix!
dsherry
left a comment
dsherry
left a comment
There was a problem hiding this comment.
Thanks @angela97lin !
One question: why didn't our dependency update bot catch this? Shouldn't we have one or more unit tests which should have failed with the removal of WholeNumber and/or copy_dataframe?
| return ww.DataColumn(ww_data) | ||
| return ww.DataTable(ww_data, copy_dataframe=True) | ||
|
|
||
| return ww.DataTable(ww_data) |
There was a problem hiding this comment.
Hmm, so is DataTable copying implicitly now? The docs for the constructor just say "create datatable"
There was a problem hiding this comment.
EDIT: Oops, didn't read your comment thoroughly. It doesn't copies implicitly.
See description for alteryx/woodwork#398!
There was a problem hiding this comment.
Thanks @angela97lin ! Filed alteryx/woodwork#420
|
@dsherry Not sure why our dependency bot didn't catch this... but our unit tests didn't fail because the last merge happened before woodwork released. Just reran tests on main and they break, as expected: https://app.circleci.com/pipelines/github/alteryx/evalml/7581/workflows/c7130efe-954f-4c2a-a8eb-5e29a90eeedc/jobs/85802 |
|
@angela97lin oh I know why... we don't have |
|
@dsherry Ah, for some reason I thought the list was directly taken from |
5 participants
copy_dataframeparameter which was removed in 0.0.6