Update `validate()` API #3142

angela97lin · 2021-12-10T19:55:15Z

Part of #3116, note that this is not being merged to main but instead, a separate branch (update_data_check_action_API). Separated out from #3152 to make it easier to review, but will merge in after to avoid multiple API changes.

This PR just updates the "action" key returned to be a dictionary that looks like "actions": {"action_list":[], "default_action": None}, rather than a list of actions.

…x/evalml into 3116_add_data_check_action_option

codecov · 2021-12-10T20:02:17Z

Codecov Report

Merging #3142 (6f974db) into update_data_check_action_API (1343a56) will not change coverage.
The diff coverage is 100.0%.

@@                     Coverage Diff                      @@
##           update_data_check_action_API   #3142   +/-   ##
============================================================
  Coverage                          99.7%   99.7%           
============================================================
  Files                               324     324           
  Lines                             31232   31232           
============================================================
  Hits                              31128   31128           
  Misses                              104     104

Impacted Files	Coverage Δ
...ta_checks_tests/test_class_imbalance_data_check.py	`100.0% <ø> (ø)`
...ta_checks_tests/test_datetime_format_data_check.py	`100.0% <ø> (ø)`
...s/data_checks_tests/test_highly_null_data_check.py	`100.0% <ø> (ø)`
...ts/data_checks_tests/test_id_columns_data_check.py	`100.0% <ø> (ø)`
..._checks_tests/test_multicollinearity_data_check.py	`100.0% <ø> (ø)`
...s/data_checks_tests/test_no_variance_data_check.py	`100.0% <ø> (ø)`
...ests/data_checks_tests/test_outliers_data_check.py	`100.0% <ø> (ø)`
...ests/data_checks_tests/test_sparsity_data_check.py	`100.0% <ø> (ø)`
...hecks_tests/test_target_distribution_data_check.py	`100.0% <ø> (ø)`
...ts/data_checks_tests/test_uniqueness_data_check.py	`100.0% <ø> (ø)`
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1343a56...6f974db. Read the comment docs.

ParthivNaresh

Changes look great! I think going from data_check_output["actions"] to data_check_output["actions"]["action_list"] is another reason that we also need to look at a cleaner way to access warnings, errors, and actions from data checks for us and users, but that's another issue entirely. Great work!

ParthivNaresh · 2022-01-04T14:26:53Z

evalml/tests/automl_tests/test_search.py

@@ -49,7 +49,7 @@ def test_search_data_check_error(
    pd.testing.assert_series_equal(target, infer_feature_types(y))


-def test_n_splits_passed_to_ts_splitting_data_check(ts_data):
+def test_n_splits_passed_to_ts_splitting_data_check():


bchen1116

Left a nit that applies to multiple files, but otherwise LGTM!

Do we have a plan on filling in default_actions? Currently, they're all None, and I'm curious 1) when their values are expected to change and 2) what values they'll hold. They don't seem too useful as of now

bchen1116 · 2022-01-04T14:55:35Z

evalml/data_checks/datetime_format_data_check.py

@@ -42,7 +42,9 @@ def validate(self, X, y):
            ...                 "details": {"columns": None, "rows": None}
            ...                 }],
            ...     "warnings": [],
-            ...     "actions": []}
+            ...     "actions": {"action_list":[], "default_action": None}}


Big nit: Sometimes there's a space between "action_list": and [] and sometimes there isn't. Can we standardize this to have the space? Occurs in multiple files.

sobs in wishing there were a doc linter

eccabay

LGTM, just left some style nitpicks!

Out of curiosity, is there currently a plan laid out for passing useful information through the "default_action" entries?

eccabay · 2022-01-04T16:14:36Z

evalml/data_checks/datetime_nan_data_check.py

+            ...
+            ...


Are these necessary? I'm not sure I understand the details of doctest syntax.

Don't think so, removing!

eccabay · 2022-01-04T16:17:56Z

evalml/data_checks/invalid_target_data_check.py

@@ -115,12 +116,12 @@ def validate(self, X, y):
            ...                             'num_null_rows': 2,
            ...                             'pct_null_rows': 50.0},
            ...                 'code': 'TARGET_HAS_NULL'}],
-            ...     'actions': [{'code': 'IMPUTE_COL',
+            ...     'actions': {"action_list": [{'code': 'IMPUTE_COL',


Mega nit: double quotes?

sobs in wishing there were a doc linter

Just went through and changed everything to double quotes :))

eccabay · 2022-01-04T16:18:54Z

evalml/data_checks/invalid_target_data_check.py

            ...                  'data_check_name': 'InvalidTargetDataCheck',
            ...                  'metadata': {'columns': None,
            ...                               'rows': None,
            ...                               'is_target': True,
-            ...                               'impute_strategy': 'mean'}}]}
+            ...                               'impute_strategy': 'mean'}}], "default_action": None}}


Another mega nit: can the "default_action" go on a new line for readability? (Same applies in a couple other places, but this is the most confusing one I think)

eccabay · 2022-01-04T16:23:24Z

evalml/data_checks/target_leakage_data_check.py

-            ...     'warnings': [{'message': "Columns 'leak', 'x' are 80.0% or more correlated with the target",
+            ...     "warnings": [{'message': "Columns 'leak', 'x' are 80.0% or more correlated with the target",


I love that you fixed this, but now the other quotes are inconsistent 😭

You're right, I must have done a replace-all somewhere--I'll go back and try to fix the other places 😭

angela97lin · 2022-01-05T05:27:19Z

@bchen1116 @eccabay Good question about the default action! As you're probably noticing, this PR still uses DataCheckActions as the output. The next step will be to update the internals to use DataCheckActionOption classes in #3152 and then add the default action, if needed. Just decided to break this down to make it easier to review, and then will merge the branch altogether :)

…d add functionality to suggest and take action on columns with null values (#3182) * Update `validate()` API (#3142) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * fix doctests * fix ts splitting test and impl * fix more ts splitting tests * fix doctest for ts data check * release notes * update target leakage data check docstring for consistency * doctest linting and cleanup * linting * fix merging main issues * Update `validate()` API to use `DataCheckActionOption` instead of `DataCheckAction` (#3152) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * add more tests * Rename `HighlyNullDataCheck` to `NullDataCheck` and update data check to return impute action for non-highly null columns. (#3197) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * init rename * retrigger * revert release nots * add new logic for detecting null cols * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix test and iteration for null data check * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * oops fix merge * add more tests * fix null data check tests * update to use per column strategy and fix tests * fix tests for data checks * fix tests and doctests * release notes * fix release notes * oops update action code * oops fix test * update wording of messages * move logic out of dict * update mode to most_frequent for impute strategies * oops fix linting and doctests * Flatten data check action ``validate`` API (#3244) * init * more cleanup * begin to clean up tests * fix more tests * updating naming to action_options and fixing more tests * fix no variance * fix another test * fixing automl tests * oops actually fix automl tests * fix the other automl tests * fixing notebook * fix data check tests * fix doctests and docs * integration tests and cleanup * cleanup based on comments * linting * clean up notebook and tests * Update `make_pipeline_from_actions` to handle null column imputation (#3237) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * init rename * retrigger * revert release nots * add new logic for detecting null cols * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix test and iteration for null data check * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * oops fix merge * add more tests * fix null data check tests * update to use per column strategy and fix tests * fix tests for data checks * fix tests and doctests * release notes * fix release notes * init * init and fix testing * fix integration test * updates test * clean up docs * lint notebook * fix tests with types * linting * release notes * update wording * update impl for natural language and datetimes, remove old tests * fix tests * fix doctest * release notes * minor cleanup * update release notes * remove impute all * linting

…3260) * Update `validate()` API (#3142) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * fix doctests * fix ts splitting test and impl * fix more ts splitting tests * fix doctest for ts data check * release notes * update target leakage data check docstring for consistency * doctest linting and cleanup * linting * fix merging main issues * Update `validate()` API to use `DataCheckActionOption` instead of `DataCheckAction` (#3152) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * add more tests * Rename `HighlyNullDataCheck` to `NullDataCheck` and update data check to return impute action for non-highly null columns. (#3197) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * init rename * retrigger * revert release nots * add new logic for detecting null cols * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix test and iteration for null data check * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * oops fix merge * add more tests * fix null data check tests * update to use per column strategy and fix tests * fix tests for data checks * fix tests and doctests * release notes * fix release notes * oops update action code * oops fix test * update wording of messages * move logic out of dict * update mode to most_frequent for impute strategies * oops fix linting and doctests * Flatten data check action ``validate`` API (#3244) * init * more cleanup * begin to clean up tests * fix more tests * updating naming to action_options and fixing more tests * fix no variance * fix another test * fixing automl tests * oops actually fix automl tests * fix the other automl tests * fixing notebook * fix data check tests * fix doctests and docs * integration tests and cleanup * cleanup based on comments * linting * clean up notebook and tests * Update `make_pipeline_from_actions` to handle null column imputation (#3237) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * init rename * retrigger * revert release nots * add new logic for detecting null cols * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix test and iteration for null data check * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * oops fix merge * add more tests * fix null data check tests * update to use per column strategy and fix tests * fix tests for data checks * fix tests and doctests * release notes * fix release notes * init * init and fix testing * fix integration test * updates test * clean up docs * lint notebook * fix tests with types * linting * release notes * update wording * update impl for natural language and datetimes, remove old tests * fix tests * fix doctest * release notes * minor cleanup * init * release notes * oops delete file * oops adding line removal Co-authored-by: chukarsten <64713315+chukarsten@users.noreply.github.com>

* Update `validate()` API (#3142) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * fix doctests * fix ts splitting test and impl * fix more ts splitting tests * fix doctest for ts data check * release notes * update target leakage data check docstring for consistency * doctest linting and cleanup * linting * fix merging main issues * Update `validate()` API to use `DataCheckActionOption` instead of `DataCheckAction` (#3152) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * add more tests * Rename `HighlyNullDataCheck` to `NullDataCheck` and update data check to return impute action for non-highly null columns. (#3197) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * init rename * retrigger * revert release nots * add new logic for detecting null cols * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix test and iteration for null data check * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * oops fix merge * add more tests * fix null data check tests * update to use per column strategy and fix tests * fix tests for data checks * fix tests and doctests * release notes * fix release notes * oops update action code * oops fix test * update wording of messages * move logic out of dict * update mode to most_frequent for impute strategies * oops fix linting and doctests * Flatten data check action ``validate`` API (#3244) * init * more cleanup * begin to clean up tests * fix more tests * updating naming to action_options and fixing more tests * fix no variance * fix another test * fixing automl tests * oops actually fix automl tests * fix the other automl tests * fixing notebook * fix data check tests * fix doctests and docs * integration tests and cleanup * cleanup based on comments * linting * clean up notebook and tests * Update `make_pipeline_from_actions` to handle null column imputation (#3237) * init * init * start updating tests * add validation code for option * remove data check updates for now * start to clean up tests and add validate_parameter tests * revert highly null dc * add in more valueerror test checking * fix test and logic for column parameters * init * update some tests to new API * fix more tests * fix doc and sparsity test * fix integration tests * fix doctests * init, update no variance * update highly null dc * fix id column dc * update target leakage dc * update sparsity dc * outliers and uniqueness dc * update target dis dc * update invalid target data check * fix doctests * fix ts splitting test and impl * fix dc validate and tests * fix more ts splitting tests * fix data check actions notebook * update to remove columns to drop * freeze * remove rows to drop * update dc tests * update doctests * fix integration tests * revert requirements * update parameters to set to empty dict * fix tests * fix doctests * retrigger * revert parameter for data check option * fix data check option test * fix more tests from updating default parameters * release notes * use empty instead of none * release notes * cleanup unnecessary code * move logic to data check option class and rename * init rename * retrigger * revert release nots * add new logic for detecting null cols * update integration tests * add tests and some cleanup * fix tests * fix pipeline util test * remove unnecessary conditional * fix test and iteration for null data check * fix naming, need to fix tests * fix tests * fix doctest * add new enums * add logic for enums * update files to use enum * add in testing for invalid enum * fix doctest by updating to_dict impl * linting * try with different base * oops revert yaml * fix tests * remove outdated code * oops fix merge * add more tests * fix null data check tests * update to use per column strategy and fix tests * fix tests for data checks * fix tests and doctests * release notes * fix release notes * init * init and fix testing * fix integration test * updates test * clean up docs * lint notebook * fix tests with types * linting * release notes * update wording * update impl for natural language and datetimes, remove old tests * fix tests * fix doctest * release notes * minor cleanup * init * lint and release notes * move release note * clean up notebook

angela97lin added 13 commits December 7, 2021 19:53

init

ba1aece

init

7fa2ad3

start updating tests

7dbe734

add validation code for option

abba247

Merge branch 'main' into 3116_add_data_check_action_option

d041dc0

remove data check updates for now

171f414

Merge branch '3116_add_data_check_action_option' of github.com:altery…

ad1d60e

…x/evalml into 3116_add_data_check_action_option

start to clean up tests and add validate_parameter tests

cc24564

Merge branch 'main' into 3116_add_data_check_action_option

e2df1ce

revert highly null dc

dff18db

add in more valueerror test checking

dafec4e

fix test and logic for column parameters

4f7195f

init

79c8924

angela97lin self-assigned this Dec 10, 2021

angela97lin added 15 commits December 10, 2021 17:38

Merge branch 'main' into 3116_update_validate

b9d0336

update some tests to new API

aca26f0

fix more tests

c41b469

fix doc and sparsity test

c2bc723

fix integration tests

023f9c5

fix doctests

a5f3d02

merge conflicts

97043d4

fix doctests

bd32fa4

fix ts splitting test and impl

9daa1cc

fix more ts splitting tests

a69c48c

Merge branch 'main' into 3116_update_validate

1f5b2f1

fix doctest for ts data check

93a7146

Merge branch 'main' into 3116_update_validate

46a8e1c

merging main

c2dda65

Merge branch 'main' into 3116_update_validate

0fc28b1

release notes

1a6222e

angela97lin changed the base branch from main to update_data_check_action_API January 2, 2022 02:53

angela97lin marked this pull request as ready for review January 3, 2022 15:49

angela97lin requested review from eccabay, ParthivNaresh, chukarsten, bchen1116, christopherbunn, dsherry, freddyaboulton and jeremyliweishih January 3, 2022 15:50

ParthivNaresh approved these changes Jan 4, 2022

View reviewed changes

bchen1116 approved these changes Jan 4, 2022

View reviewed changes

eccabay approved these changes Jan 4, 2022

View reviewed changes

angela97lin added 4 commits January 4, 2022 15:29

update target leakage data check docstring for consistency

6b25210

Merge branch 'main' into 3116_update_validate

d3f3f4f

doctest linting and cleanup

4b208ad

linting

6f974db

angela97lin merged commit c939fa6 into update_data_check_action_API Jan 5, 2022

angela97lin deleted the 3116_update_validate branch January 5, 2022 05:27

angela97lin mentioned this pull request Jan 5, 2022

Update validate() API to use DataCheckActionOption instead of DataCheckAction #3152

Merged

angela97lin mentioned this pull request Jan 25, 2022

Release 0.43.0 #3279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `validate()` API #3142

Update `validate()` API #3142

angela97lin commented Dec 10, 2021 •

edited

Loading

codecov bot commented Dec 10, 2021 •

edited

Loading

ParthivNaresh left a comment

ParthivNaresh Jan 4, 2022

bchen1116 left a comment

bchen1116 Jan 4, 2022

angela97lin Jan 5, 2022

eccabay left a comment

eccabay Jan 4, 2022

angela97lin Jan 5, 2022

eccabay Jan 4, 2022

angela97lin Jan 5, 2022

eccabay Jan 4, 2022

angela97lin Jan 5, 2022

eccabay Jan 4, 2022

angela97lin Jan 4, 2022

angela97lin commented Jan 5, 2022

		... 'warnings': [{'message': "Columns 'leak', 'x' are 80.0% or more correlated with the target",
		... "warnings": [{'message': "Columns 'leak', 'x' are 80.0% or more correlated with the target",

Update validate() API #3142

Update validate() API #3142

Conversation

angela97lin commented Dec 10, 2021 • edited Loading

codecov bot commented Dec 10, 2021 • edited Loading

Codecov Report

ParthivNaresh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bchen1116 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eccabay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angela97lin commented Jan 5, 2022

Update `validate()` API #3142

Update `validate()` API #3142

angela97lin commented Dec 10, 2021 •

edited

Loading

codecov bot commented Dec 10, 2021 •

edited

Loading