Support numbers in json. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change it would fail: TypeError: no implicit conversion of Fixnum into String
|
Hi plu, All fine in Hamburg. Berlin as well? Thanks for coming up with this pull request, I really appreciate it! Cheers, |
|
I just released version |
|
Cool thanks 👍 Yea, all good here too :). Just feels like the summer is over already... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moin Thorsten,
I hope all is good in HH :)?!
I'm using your great gem to test my JSON responses. Today I noticed that using regexes together with plain numbers (vs. quoted ones "1") is not working (tested on 2.1.2p95). It throws a TypeError:
TypeError: no implicit conversion of Fixnum into StringI have fixed that issue and added a test for it.
Cheers,
plu