compute controller #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Tests are broken due to Resource not being renderable into headers. |
alvarolopez
force-pushed
the
compute_controller
branch
from
b9f0fb9
to
b6fa794
Compare
According to the OCCI specification, the accept header MUST be handled as follows: - If Accept is empty, the returned content-type should be text/plain - If Accept is "*/*", the returned content-type should be text/plain - If Accept cannot be understood, a 406 error should be returned. We are still missing the handling of the content-type header (that must indicate the type of the data being sent, if any) that should be checked against the available parsers (this is still missing).
Check that we are actually raising the proper exception when there is a bad request in the compute controller create method.
200, 201 and 202 are valid return codes that will contain a JSON, so we should check for them also.
If after serializing the response we do not have a body or headers (for example after a delete), we should return a 204 code.
Conflicts: ooi/api/base.py
New occi.infrastructure.storage and associated tests. Added StorageLinks
- New parser and validator for create methods. - Includes schemes in the mixin class to allow comparisons - Fix scheme builder in helper (was missing # at the end) - Update tests
Everything is now under the same module (wsgi). Request object includes methods for parsing a validating the user input. Fixed the compute method which was still using the old body for creating the VM. Added tests for parser.
Missing the validation tests.
In section 3.6.5 it is said that a server must indicate the version that it supports via the Server HTTP header. We have to advertise this even when a fault is returned.
We only support OCCI/1.1, so if we have another version we have to raise a 501 not implemented error.
According to section 3.6.7, to comply with the RFC5785 we should implement the query interface functionality under the authrority path "/.well-known/org/ogf/occi/-/".
alvarolopez
force-pushed
the
compute_controller
branch
from
a8d4178
to
b52984d
Compare
According to OCCI specification, operations on paths that are not resource instances or location paths, the path must end with "/". We need to add the rule manually, since otherwise routes will strip out all the slashes when generating the resources rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.