Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launcher): 🐛 Restore Launcher #2058

Merged
merged 6 commits into from
Apr 4, 2024
Merged

fix(launcher): 🐛 Restore Launcher #2058

merged 6 commits into from
Apr 4, 2024

Conversation

zarik5
Copy link
Member

@zarik5 zarik5 commented Apr 2, 2024

Restore launcher with basic functionality:

  • Download and extract either the streamer windows zip or linux tar.gz
  • Download and install client APK

WIP: need to finish removing most unwraps.

@Meister1593
Copy link
Collaborator

image
Can't seem to open streamers after downloading one

@Meister1593
Copy link
Collaborator

I would rearrange buttons to be:
Launch (green color); Install APK; Open directory; Edit;
image
Also edit seem to only have remov button now, what's planned for it?...

@zarik5
Copy link
Member Author

zarik5 commented Apr 2, 2024

Also edit seem to only have remov button now, what's planned for it

Possibly some session backup mechanism

@Meister1593
Copy link
Collaborator

Also i think considering launcher will manage multiple versions, we might need to think about making versions use different session files, otherwise it's gonna parse it back/forth with some settings default changes from previous versions

@zarik5
Copy link
Member Author

zarik5 commented Apr 2, 2024

By default we should have each version manage its own session file, and optionally add the ability to sync it between version, or manage a global one

@Meister1593
Copy link
Collaborator

Oh and also, downgrading versions by default isn't possible through adb (INSTALL_FAILED_VERSION_DOWNGRADE), you need to do adb install -d path-to-apk (-d flag) to be able to downgrade

@zarik5
Copy link
Member Author

zarik5 commented Apr 2, 2024

you need to do adb install -d path-to-apk (-d flag) to be able to downgrade

Nice one! I might also contribute this to cargo-apk

@Meister1593
Copy link
Collaborator

As for adb and cabled mode later, i was planning to use mozdevice
It requires launching adb prior to using it (it basically connects to adb locally), so i think it would be nice to expose adb folder somewhere in codebase

@zarik5
Copy link
Member Author

zarik5 commented Apr 2, 2024

For the sake of portability, I think it's better to download adb inside each specific version folder. This is especially useful if ALVR was not downloaded through the launcher. but first test for global adb like the launcher.

@Meister1593
Copy link
Collaborator

can't seem to see icon (this is wayland fallback)
image

@Meister1593
Copy link
Collaborator

tbf it's same for streamer app (no icon)

@Meister1593
Copy link
Collaborator

might be winit issue (it supports only windows/x11)
https://docs.rs/winit/latest/winit/window/struct.Window.html#method.set_window_icon

@Vixea
Copy link
Collaborator

Vixea commented Apr 3, 2024

@Meister1593 nah its a wayland issue(as in they don't allow it) for "security"

@zarik5 zarik5 merged commit ea34281 into master Apr 4, 2024
7 checks passed
@zarik5 zarik5 deleted the finish-launcher branch April 4, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants