minor: string to bytes.Buffer #7
Conversation
Konstantin8105
commented
Aug 26, 2018
Konstantin8105
commented
- minor optimization "string to bytes.Buffer"
- ignore symbols outside english letters.
| @@ -33,24 +33,25 @@ func (h *hacker) Encode(r io.Reader) ([]byte, error) { | |||
| } | |||
| data := string(d) | |||
| data = strings.ToUpper(data) | |||
| var encodedValue string | |||
| var encode bytes.Buffer | |||
There was a problem hiding this comment.
change this variable name to encodedBufferor encodedValue. encode is a verb
| } | ||
| } | ||
|
|
||
| func TestEncodeNotValidLetter(t *testing.T) { |
There was a problem hiding this comment.
This is a valid test case. Can you rename this to TestEncodeValidLetter
There was a problem hiding this comment.
Yes, test is valid(Ok). But it is valid test for string with not valid letter(hieroglyph). Could you clarify your opinion?
There was a problem hiding this comment.
The letters used in this test is not causing an error, we do not have support of any other language other than english yet, therefore the encode should error out in this scenario but currently it is translating partially without informing the user that part of the data was not translated to morse
|
Also, could you open an issue for this improvement |
|
Closing the PR because of inactivity |
