New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gitalk comment #86

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Ferrari
Copy link

Ferrari commented Jan 29, 2019

Add the support to gitalk, a Github-based comment system.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #86 into master will decrease coverage by 1.92%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   95.71%   93.79%   -1.93%     
==========================================
  Files          28       28              
  Lines         140      145       +5     
  Branches        8        9       +1     
==========================================
+ Hits          134      136       +2     
- Misses          6        8       +2     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/templates/post-template.js 100% <ø> (ø) ⬆️
src/components/Post/Comments/Comments.js 61.53% <50%> (-13.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d01bb...f36e041. Read the comment docs.

@alxshelepenok
Copy link
Owner

alxshelepenok left a comment

It is also necessary to resolve conflicts in the package.json

@@ -1,25 +1,48 @@
import React from 'react';
import { graphql, StaticQuery } from 'gatsby';
import ReactDisqusComments from 'react-disqus-comments';
import md5 from 'md5';
import 'gitalk/dist/gitalk.css';

This comment has been minimized.

@alxshelepenok

alxshelepenok Feb 13, 2019

Owner

Styles need to be moved to _base.scss (src/assets/scss/_base.scss)

@@ -1,25 +1,48 @@
import React from 'react';
import { graphql, StaticQuery } from 'gatsby';
import ReactDisqusComments from 'react-disqus-comments';
import md5 from 'md5';
import 'gitalk/dist/gitalk.css';
import GitalkComponent from 'gitalk/dist/gitalk-component';

export const PureComments = ({ data, postTitle, postSlug }) => {
const {
siteUrl,

This comment has been minimized.

@alxshelepenok

alxshelepenok Feb 13, 2019

Owner

siteUrl should be replaced by url

shortname={disqusShortname}
identifier={postTitle}
title={postTitle}
url={siteUrl + postSlug}

This comment has been minimized.

@alxshelepenok

alxshelepenok Feb 13, 2019

Owner

siteUrl should be replaced by url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment