Support gitalk comment #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 95.71% 93.79% -1.93%
==========================================
Files 28 28
Lines 140 145 +5
Branches 8 9 +1
==========================================
+ Hits 134 136 +2
- Misses 6 8 +2
- Partials 0 1 +1
Continue to review full report at Codecov.
|
alxshelepenok
requested changes
Feb 13, 2019
| @@ -1,25 +1,48 @@ | |||
| import React from 'react'; | |||
| import { graphql, StaticQuery } from 'gatsby'; | |||
| import ReactDisqusComments from 'react-disqus-comments'; | |||
| import md5 from 'md5'; | |||
| import 'gitalk/dist/gitalk.css'; | |||
There was a problem hiding this comment.
Styles need to be moved to _base.scss (src/assets/scss/_base.scss)
| @@ -1,25 +1,48 @@ | |||
| import React from 'react'; | |||
| import { graphql, StaticQuery } from 'gatsby'; | |||
| import ReactDisqusComments from 'react-disqus-comments'; | |||
| import md5 from 'md5'; | |||
| import 'gitalk/dist/gitalk.css'; | |||
| import GitalkComponent from 'gitalk/dist/gitalk-component'; | |||
|
|
|||
| export const PureComments = ({ data, postTitle, postSlug }) => { | |||
| const { | |||
| siteUrl, | |||
There was a problem hiding this comment.
siteUrl should be replaced by url
| shortname={disqusShortname} | ||
| identifier={postTitle} | ||
| title={postTitle} | ||
| url={siteUrl + postSlug} |
There was a problem hiding this comment.
siteUrl should be replaced by url
|
I’m closing this pull request for now because of inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support to gitalk, a Github-based comment system.