Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script issues - support for UDMPro v2.4.23 #32

Closed
mojo333 opened this issue Dec 16, 2022 · 2 comments
Closed

Script issues - support for UDMPro v2.4.23 #32

mojo333 opened this issue Dec 16, 2022 · 2 comments

Comments

@mojo333
Copy link

mojo333 commented Dec 16, 2022

  1. deploy.sh fails for me as I get the following when executing:
root@UDMP:/data/letsencrypt/ubios-cert-main# ./deploy.sh
Unsupported model: UniFi Dream Machine Pro

Adding an echo just before the case statement shows that ${MODEL} evaluates to just "UniFi" and hence why the case statement fails... something to do with spaces in the variable. Not sure how to fix this as I'm no bsh expert.

  1. ubios-cert.sh also needs updated code to handle UDMPro 2.4.23 as was done for deploy.sh - see excerpt below:
# When running in UDM SE / UDR, the applications are not running in containers
case "$(ubnt-device-info model || true)" in "UniFi Dream Machine SE"|"UniFi Dream Router")
	# But here, the same command will be executed but inside unifi-os container
	IS_UNIFI_2='true'
	;;
esac
@ausil
Copy link
Contributor

ausil commented Dec 16, 2022

I have submitted a fix in PR #33 sorry I must have missed that bit when testing it late last night

ausil added a commit to ausil/ubios-cert that referenced this issue Dec 16, 2022
Like the chages to deploy.sh to cater for 2.x being rolled out in EA
update the captive portal support to look at the firmware version when
deciding to use podman or not. Fixes alxwolf#32

Signed-off-by: Dennis Gilmore <dennis@ausil.us>
@mojo333
Copy link
Author

mojo333 commented Dec 16, 2022

I must have missed that bit when testing it late last night

I'm keen to get this working, so thanks for your support on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants