Create endpoints to find, create, update contact in Maropost #4
Conversation
|
📖 |
lib/maropost/api.rb
Outdated
| def self.find(email) | ||
| url = "#{Maropost.configuration.api_url}/contacts/email.json?contact[email]=#{email}" | ||
|
|
||
| response = RestClient::Request.execute( |
There was a problem hiding this comment.
hey Serene...we've wrapped RestClient requests to do some additional logging (https://rubygems.org/gems/rest-client-jogger)...could you update these RestClient::Request.executes to use that? Here's an example (but @jessedoyle might be able to let you know how we are doing it in the new DE app):
https://github.com/amaabca/ama_oauth_client/blob/master/lib/ama_oauth_client/sudo_mode/model.rb#L5
Then to get the logging you just have to add this to the app (if it isn't there already):
RestClient::Jogger::EventSubscriber.new.subscribe
lib/maropost/api.rb
Outdated
| url: url, | ||
| payload: { auth_token: Maropost.configuration.auth_token }.to_json, | ||
| headers: { content_type: 'application/json', accept: 'application/json' }, | ||
| verify_ssl: OpenSSL::SSL::VERIFY_NONE |
There was a problem hiding this comment.
can we also change this (and the other calls) to verify SSL?
lib/maropost/api.rb
Outdated
| def self.find(email) | ||
| url = "#{Maropost.configuration.api_url}/contacts/email.json?contact[email]=#{email}" | ||
|
|
||
| response = RestClient::Request.execute( |
There was a problem hiding this comment.
this is repeated for each method can this be extracted to a method that takes the url, payload, and method?
|
can you add a commit message with examples of the api calls |
|
💩 |
|
👋 |
|
🐘 🐘 🐘 |
No description provided.