Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a Result object for easy check if a request was successful or had a warning/error #2

Closed
DerMika opened this issue Mar 7, 2016 · 1 comment
Closed

Use a Result object for easy check if a request was successful or had a warning/error #2

DerMika opened this issue Mar 7, 2016 · 1 comment
Assignees
@DerMika
Labels
enhancement
Milestone
1.0

Comments

@DerMika
Copy link
Collaborator

DerMika commented Mar 7, 2016

We have to make it easier to check if a call was successful, or if a warning or an error occurred.

We'll implement this by returning a Result object which has properties like

  • status (OK | WARN | ERROR)
  • warnings = []
  • errors = []
  • response

We should also re-think the asString property so that it's consistent with this Result object.
@DerMika DerMika added this to the 0.1 milestone Mar 8, 2016
@DerMika DerMika self-assigned this Apr 27, 2016
DerMika added a commit that referenced this issue May 17, 2016
@DerMika
First implementation of fix for #2 - Return a Result object
9b34503
DerMika added a commit that referenced this issue May 30, 2016
@DerMika
Implementing more response handler message checks #2
1c542fb
DerMika added a commit that referenced this issue May 31, 2016
@DerMika
Further implementation of error checks in ResponseHandler - do not th…
fe20c14 
…row soapfaults anymore - provide message version in Session Handler SendResult - #2
@DerMika
Copy link
Collaborator Author

DerMika commented Jun 20, 2016 •
edited
Loading

This is fully implemented with commit c403535.

Documentation can be found here: https://github.com/amabnl/amadeus-ws-client/blob/develop/docs/samples.rst#handling-the-response

@DerMika DerMika closed this as completed Jun 20, 2016
DerMika added a commit that referenced this issue Jun 21, 2016
@DerMika
Support for detecting errors in PNR_RetrieveAndDisplay messages (#2) …
7cfe1b2 
…+ Code coverage improvements
@JustBeDigital JustBeDigital mentioned this issue Aug 18, 2017
Closed
@AmiinosEddagh AmiinosEddagh mentioned this issue Feb 14, 2018
Closed
@zhaonan0218 zhaonan0218 mentioned this issue Mar 15, 2018
Closed
@saaqeb saaqeb mentioned this issue Oct 29, 2018
Open
atomy pushed a commit to mlamm/amadeus-ws-client that referenced this issue Nov 26, 2018
@marcuswinkler
Merge pull request amabnl#2 in FLIGHT/service.amadeus from feature/VA…
dbcced7 
…N-336-ama-request-service-move-result-limit to master

* commit '9bab7fed2264f0580c996e22a90f5e8ee9d0daa3':
  VAN-336 AMA request service / move result limit field in request changed API Doc updated validation updated tests
  VAN-336 AMA request service / move result limit field in request changed API Doc updated composer updated Request Mapping
@ketan077 ketan077 mentioned this issue Jan 27, 2019
Closed
@fayax fayax mentioned this issue Jan 30, 2019
Closed
hammock pushed a commit to hammock/amadeus-ws-client that referenced this issue Apr 3, 2020
Remove ext-xsl dependency [amabnl#2]
a95c5d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DerMika DerMika

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@DerMika