ClickHouse: Support migrations on cluster #432
Conversation
| } | ||
|
|
||
| // Makes sure driver creatinon is atomic | ||
| func TestDriverCreationSanity(t *testing.T) { |
There was a problem hiding this comment.
Nice additional test. Maybe we should suggest enforcing it for all drivers.
|
@FatherCandle I gave you commit access, so feel free to merge if there is sufficient consensus on code review + test cases. |
That's awesome :) |
There was a problem hiding this comment.
This all looks great!
Would you mind also updating the ClickHouse section of the README with documentation listing the 4 new connection query params this PR introduces (on_cluster, zoo_path, cluster_macro, and replica_macro), too, please?
@dossy |
Adding functionally to support usage of Dbmate with ClickHouse cluster.
Easy default usage with just supplying "on_cluster" query parameter.
Took the approach of trying to keep the changes simple without breaking any existing stuff.
95% of the changes in the PR are for the tests and setups of the ClickHouse cluster dockers.
Will happily answer any questions, and would really appreciate reviews.
Solves existing requests in discussions:
#356
#244