avoid parser exception on 204 no content #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyroux
reviewed
Jan 19, 2021
| @@ -121,6 +121,11 @@ private void parseData(HTTPClient client) { | |||
|
|
|||
| // Tries to read the body. | |||
| private String readBody() { | |||
| // Workaround to avoid ParserException when status code is 204 | |||
| if (statusCode == 204) { | |||
| body = "{ \"data\": { } } "; | |||
There was a problem hiding this comment.
Does it mean you want the SDK to return a body "{ "data": { } } " when doing a delete?
tsolakoua
changed the title
tsolakoua
changed the title
anthonyroux
suggested changes
Feb 4, 2021
| @@ -67,6 +66,9 @@ protected void parse(HTTPClient client) { | |||
| // Detects of any exceptions have occured and throws the appropriate exceptions. | |||
| protected void detectError(HTTPClient client) throws ResponseException { | |||
| ResponseException exception = null; | |||
| if (statusCode == 204) { | |||
There was a problem hiding this comment.
should it be part of the if else if else if part instead of being an if isolated?
| @@ -97,6 +99,9 @@ private void parseStatusCode() { | |||
|
|
|||
| // Tries to parse the data | |||
| private void parseData(HTTPClient client) { | |||
| if (this.statusCode == 204) { | |||
There was a problem hiding this comment.
Instead of having it here with an empty return could it be in the same file line 64 (in the parse method) with something like:
protected void parse(HTTPClient client) {
parseStatusCode();
if(this.statusCode != 204) {
parseData(client);
}
}
anthonyroux
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95