Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added screen transitions. #63

Merged
merged 3 commits into from
Mar 30, 2017
Merged

Conversation

octacode
Copy link
Member

@octacode octacode commented Mar 9, 2017

I have added a screen transition of fade in and fade out when using intents.
Fixes #62

@megabitdragon
Copy link
Member

This is a matter of personal preference. I will not merge until we discuss it internally.

@cpg
Copy link
Member

cpg commented Mar 15, 2017

This seems to make things just a little slower, though I'm not sure.

I could go either way on this one. It does not look like a lot of code, in any case, so it can be reversed quickly if we have to. Unless there are any objections, I will merge it in a few days.

@megabitdragon megabitdragon merged commit 75ec566 into amahi:master Mar 30, 2017
@octacode octacode deleted the screen_transits branch August 14, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants