thumbnail regeneration resolved

[iswiftshek]

Previously, new thumbnails for files were being generated every time we opened a folder and thus it would take time for thumbnails (audio, video, documents) to load.

Now, thumbnails are generated only once and then loaded from cache whenever called. It can be verified in the logs.

[cpg]

I don't know for sure, but I think this may not be working well. I get lots of these after re-visiting a page and there is

AmahiAnywhere(19456,0x170163000) malloc: *** set a breakpoint in malloc_error_break to debug
AmahiAnywhere(19456,0x1701ef000) malloc: can't allocate region
*** mach_vm_map(size=2572386304) failed (error code=3)
AmahiAnywhere(19456,0x1701ef000) malloc: *** set a breakpoint in malloc_error_break to debug
AmahiAnywhere(19456,0x1701ef000) malloc: can't allocate region
*** mach_vm_map(size=1763590144) failed (error code=3)
AmahiAnywhere(19456,0x1701ef000) malloc: *** set a breakpoint in malloc_error_break to debug
AmahiAnywhere(19456,0x1701ef000) malloc: can't allocate region
*** mach_vm_map(size=1983725568) failed (error code=3)
AmahiAnywhere(19456,0x1701ef000) malloc: *** set a breakpoint in malloc_error_break to debug
AmahiAnywhere(19456,0x1701ef000) malloc: can't allocate region
*** mach_vm_map(size=1763590144) failed (error code=3)
AmahiAnywhere(19456,0x1701ef000) malloc: *** set a breakpoint in malloc_error_break to debug

in fact, I have been able to get to a folder, see all the thumbnails for the music, then browse down and up and some music does no longer have thumbnails. I think I see the malloc messages above in sync with these issues starting, but I am not sure.

[iswiftshek]

The disappearance of thumbnails on scrolling.. is it happening specifically on this pr?
Also, does it happen for the video files or any other type of file?

[cpg]

It happens for mp3 files. I did not try with other types.

It does not seem to happen in the beta branch. Check with a folder full of mp3s.

[cpg]

Where are we on this one?

[iswiftshek]

Does the app also crash/slow down (become less responsive) with those malloc errors?

[cpg]

Where are we on this?

[iswiftshek]

This PR has conflicts, so I am closing it
I will look into it and send another one