Make colorMin an optional argument
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the example program in the README in TypeScript, I got type-checking errors because it said `colorMin` was required in `renderAmplitudeProgram`. This change corrects the type definition to make `colorMin` optional.
|
thanks for the pr! this has been released in version 0.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for writing this library! I saw it on Twitter and was super excited. You inspired me to go on a textbook-reading day with my friend about the Navier-Stokes equations a couple weeks ago.
Anyway I was trying to use the library and caught a small bug.
When running the example program in the README in TypeScript, I got type-checking errors because it said
colorMinwas required inrenderAmplitudeProgram.This change corrects the type definition to make
colorMinoptional.