Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Confirmation message on ctrl + w #92

Merged
merged 3 commits into from
Oct 4, 2020
Merged

ADD: Confirmation message on ctrl + w #92

merged 3 commits into from
Oct 4, 2020

Conversation

MarceloZapatta
Copy link
Contributor

Hi!

This feature add an confirmation message on cmd/ctrl + w before closing a tab.

amanharwara
amanharwara requested changes Oct 2, 2020
View reviewed changes
Copy link
Owner

@amanharwara amanharwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the dialog box says "Exit" which doesn't make sense. It show be something along the lines of "Close Tab?"...

Also, can you change it so it follows the "Prompt When Closing Tab" setting?

@MarceloZapatta MarceloZapatta deleted the feature/prevent-close branch October 4, 2020 03:15
@MarceloZapatta MarceloZapatta restored the feature/prevent-close branch October 4, 2020 03:16
@MarceloZapatta
Copy link
Contributor Author

@amanharwara changed the title in dialog and follows "Exit prompt" setting.

@MarceloZapatta MarceloZapatta reopened this Oct 4, 2020
@amanharwara amanharwara merged commit aa1430f into amanharwara:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanharwara amanharwara amanharwara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarceloZapatta @amanharwara