feat: Set secure flag for NEXT_LOCALE cookie (ON HOLD)
#1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amannn
changed the title
secure flag for NEXT_LOCALE cookiesecure flag for NEXT_LOCALE cookie
amannn
changed the title
secure flag for NEXT_LOCALE cookiesecure flag for NEXT_LOCALE cookie (ON HOLD)
|
As discussed in #1268 (comment), the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a security enhancement and will disallow users to read the
NEXT_LOCALEcookie if the website is served over HTTP. The only exception is onlocalhost.See also: Block access to your cookies on MDN
If you'd like to unset this flag, you can compose the middleware and modify the cookie accordingly before the response is returned.
Fixes #1268