Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspect incorrect in the upper left quadrant #210

Closed
ecoon opened this issue Oct 2, 2023 · 1 comment · Fixed by #211
Closed

aspect incorrect in the upper left quadrant #210

ecoon opened this issue Oct 2, 2023 · 1 comment · Fixed by #211
Assignees
@ecoon

Comments

@ecoon
Copy link
Collaborator

ecoon commented Oct 2, 2023

Due to a misunderstanding of cmath constants, the aspect was incorrectly computed in the upper-left (NW) quadrant. It seems like this ought to have had a big effect, but maybe not if the slope is fairly small (which it is for most runs).

Reported by @pinshuai and @gaobhub
@ecoon ecoon self-assigned this Oct 2, 2023
@ecoon
Copy link
Collaborator Author

ecoon commented Oct 2, 2023

Note the fix for this will go on both master and be a new patch release for 1.4

@ecoon ecoon mentioned this issue Oct 2, 2023
Merged
@ecoon ecoon closed this as completed in #211 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecoon ecoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes bug in aspect in the NW quadrant due to mistake in cmath constant amanzi/ats
1 participant
@ecoon