You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently volumetric_deformation is based on two enums:
a "DeformStrategy" which is algorithmic (global optimization vs MSTK's internal vs cell-to-node averaging) and describes how to go from cell volume changes to nodal coordinate changes
a "DeformMode" which describes how to calculate the volume changes.
Clearly the latter should go to evaluators. The former probably can't.
Also, there is an implied dependency on base porosity that isn't required.
Also, keys are hard-coded.
Also, global optimization uses a very old matrix -- does this code-branch even work? This in particular needs regression tests, as it tests MSTK as well which can be fragile.
The text was updated successfully, but these errors were encountered:
Currently volumetric_deformation is based on two enums:
a "DeformStrategy" which is algorithmic (global optimization vs MSTK's internal vs cell-to-node averaging) and describes how to go from cell volume changes to nodal coordinate changes
a "DeformMode" which describes how to calculate the volume changes.
Clearly the latter should go to evaluators. The former probably can't.
Also, there is an implied dependency on base porosity that isn't required.
Also, keys are hard-coded.
Also, global optimization uses a very old matrix -- does this code-branch even work? This in particular needs regression tests, as it tests MSTK as well which can be fragile.
The text was updated successfully, but these errors were encountered: