Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor volumetric_deformation to use evaluators #37

Closed
ecoon opened this issue Apr 2, 2020 · 1 comment
Closed

refactor volumetric_deformation to use evaluators #37

ecoon opened this issue Apr 2, 2020 · 1 comment
Assignees

Comments

@ecoon
Copy link
Collaborator

ecoon commented Apr 2, 2020

Currently volumetric_deformation is based on two enums:

a "DeformStrategy" which is algorithmic (global optimization vs MSTK's internal vs cell-to-node averaging) and describes how to go from cell volume changes to nodal coordinate changes

a "DeformMode" which describes how to calculate the volume changes.

Clearly the latter should go to evaluators. The former probably can't.

Also, there is an implied dependency on base porosity that isn't required.

Also, keys are hard-coded.

Also, global optimization uses a very old matrix -- does this code-branch even work? This in particular needs regression tests, as it tests MSTK as well which can be fragile.

@ecoon ecoon self-assigned this Apr 2, 2020
@ecoon
Copy link
Collaborator Author

ecoon commented May 9, 2023

Some of this has been resolved, some of this has been deleted, and some of this may still be applicable. Ignoring it for now.

@ecoon ecoon closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant