New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent supress option names #38

Closed

ecoon opened this issue Apr 2, 2020 · 1 comment

Assignees

Collaborator

ecoon commented Apr 2, 2020

Fix, and deprecate/error/something on terms in mpc_subsurface:

"supress Jacobian terms: div hq / dp,T"

missing initial "d", should be "d div hq / dp,T"

compared to:

"supress Jacobian terms: d div q / dT"
"supress Jacobian terms: d div K grad T / dp"

ecoon self-assigned this

Collaborator Author

ecoon commented Apr 2, 2020 •

edited

Loading

While doing this, also fix the hard-coded root variable names, e.g.

temp_key_ = Keys::getKey(domain_name_, "temperature");

should be

temp_key_ = Keys::readKey(plist_, domain_name_, "temperature", "temperature");

and add to input spec documentation.

ecoon closed this as completed in

1a107ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment