Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-detecting watchman #31

Closed
stefanpenner opened this issue Nov 7, 2014 · 4 comments
Closed

auto-detecting watchman #31

stefanpenner opened this issue Nov 7, 2014 · 4 comments

Comments

@stefanpenner
Copy link
Collaborator

thoughts?

@amasad
Copy link
Owner

amasad commented Nov 7, 2014

It should be easy to add an auto option to the sane() function that chooses the best thing available. I worry about making it the default and tell people that it will always do the right thing.

@stefanpenner
Copy link
Collaborator Author

It's fine to not make auto the default here, but let consumers of this library make that choice.
e.g.

sane.autoWatch('...');

It would also be nice if we where provided with a way to see which watcher auto choose.

@stefanpenner
Copy link
Collaborator Author

ultimately, this isn't a blocker for me merely a thought.

@sandstrom
Copy link

@stefanpenner Today, a few years later, would it make sense to merge watch-detector (https://github.com/chrmod/watch-detector/) with this repo?

I'm working on updates to the docs for ember-cli and wanted to see if the 'missing watchman' console message had changed. I had to dig a bit to find it:

  1. I checked ember-cli source, noticed that watching is handled by broccoli.
  2. Found broccoli-sane-watcher, saw that it's merged into broccoli core.
  3. Checked broccoli core, saw that it used watch-detector.

I know this is how the NPM ecosystem works, everything is broken down into atoms and spread over multiple packages. 😄 But sometimes it would be easier if these were at least collected under the same namespace (e.g. @sane/core, @sane/watch-detector).

Since you've already suggested adding watch-detection to sane (this old issue) and now seem to have commit rights to the repo, I just wanted to hear your thoughts on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants