Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code optimization #7

Merged
merged 2 commits into from
Jun 18, 2018
Merged

code optimization #7

merged 2 commits into from
Jun 18, 2018

Conversation

amateja
Copy link
Owner

@amateja amateja commented Jun 18, 2018

Code is simplified with use of list and dict comprehensions and bit-wise operators. It should be also a bit faster. No library functional logic is changed but two minor breaking changes should be noted here:

  • bitoptions.utils.number2powers returns a generator not a list, values are now sorted in ascending order
  • bitoptions.utils.BitOptions._initialize_lookup method is removed.

@coveralls
Copy link

coveralls commented Jun 18, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 80aeb04 on feature/optimization into 5caae0c on develop.

@amateja amateja merged commit 8953f9a into develop Jun 18, 2018
@amateja amateja deleted the feature/optimization branch June 18, 2018 08:44
@amateja amateja changed the title Feature/optimization code optimization Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants