Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed overriding of dimension name in structure parser v2.1 #129

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

charphi
Copy link
Contributor

@charphi charphi commented Jun 12, 2017

When parsing dimensions in a data structure v2.1, the last dimension name is overridden by the time dimension name.

@amattioc
Copy link
Owner

Hi @charphi, thanks a lot. Can you also add a failing scenario? I cannot reproduce the error...

Best, Attilio

@charphi
Copy link
Contributor Author

charphi commented Jun 13, 2017

When loading the data structure of the dataflow ECB,TRD,1.0 from ECB, it returns 8 dimensions.
(https://sdw-wsrest.ecb.europa.eu/service/datastructure/ECB/ECB_TRD1/1.0?references=children)

The last dimension is TRD_SUFFIX.
Its name is "Time period or range" (TIME_PERIOD concept) instead of "Series variation -TRD context" (TRD_SUFFIX concept).

@amattioc
Copy link
Owner

Thanks, I had not got that the problem was in the name and not the id of the dimension...

@amattioc amattioc merged commit 0597de0 into amattioc:master Jun 13, 2017
@charphi
Copy link
Contributor Author

charphi commented Jun 14, 2017

Indeed, the description was a bit misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants